Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctype_xdigit error on entware rtorrent-easy-install package #2553

Open
4 tasks done
OverKilL013 opened this issue Aug 15, 2023 · 2 comments
Open
4 tasks done

ctype_xdigit error on entware rtorrent-easy-install package #2553

OverKilL013 opened this issue Aug 15, 2023 · 2 comments

Comments

@OverKilL013
Copy link

OverKilL013 commented Aug 15, 2023

Please complete the following tasks.

  • Web browser cache cleared
  • Link provided to install script if applicable
  • Not using broken rtinst install script
  • Web browser, ruTorrent, PHP and OS version provided

Tell us about your environment

FF: 116.0.2
ruTorrent: 4.1.5
php: 8.2.6
os: asus merlin + entware at asus ax92u router

Tell us how you installed ruTorrent

entware opkg rtorrent-easy-install

Describe the bug

after installatuion the plugin
when i try to change direction of torrent file
nothing was happend

Steps to reproduce

click on torrent
select menu "save to"
select path
click "ok"
see still screen and waiting for nothing

Expected behavior

the file must be replaced to another directory
and i would see the result in webui

Additional context

I check the log file with enabled debug
the problrm was in action.php at line 36
the function ctype_xdigit was undefined

so I had replaced
if( !ctype_xdigit($hash))
with
if(!preg_match('/^[0-9a-f]{40}$/i', $hash))
and all return to work

@stickz
Copy link
Collaborator

stickz commented Aug 16, 2023

Feel free to submit a pull request toward v4.2 branch. You can call function_exists("ctype_xdigit"). If it doesn't exist, you can use preg_match instead. I don't have a problem with adding support for different platforms. v4.1 is done, after the next hotfix.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants