Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile friendly interface #2494

Open
blixten85 opened this issue Apr 25, 2023 · 10 comments
Open

Mobile friendly interface #2494

blixten85 opened this issue Apr 25, 2023 · 10 comments

Comments

@blixten85
Copy link

Is your feature request related to a problem?

Yes

Describe the solution you'd like

I would not cry if rutorrent was mobile friendly.
As it is now you must access a computer to make changes, add or view this and that.

Additional context

No response

@alekslyse
Copy link

I will second that!

@stickz
Copy link
Collaborator

stickz commented Apr 28, 2023

@blixten85 @alekslyse Please feel free to give the development branch a try with the latest Mobile Design Enhancements. Let me know what you think about 4206060. It's not perfect yet, but the design is more mobile friendly.

@xombiemp
Copy link
Collaborator

You can also try out https://github.com/xombiemp/rutorrentMobile

@stickz
Copy link
Collaborator

stickz commented May 12, 2023

@xombiemp Would you be interested in submitting mobile design improvements to upstream? I have the necessary qualifications to review them and get them merged into ruTorrent v4.2. I took multiple courses on mobile first web design.

I got started on a few in the develop branch. I'm looking for a button currently to toggle visibility for the CatList and HDivider. We can apply adjusted CSS styles using media queries and maintain the desktop layout. Javascript is great for toggles as well.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 17, 2024
@castillo92
Copy link

castillo92 commented Apr 2, 2024

@stickz Could we revive this issue?

With the latest ruTorrent update 4.3, the @xombiemp mobile version stop working. It shows the following errors in screen. I can not help so much because I am not a JavaScript programmer

Error 1
Error 2
Error 3
Error 4

These errors were displayed for a very short time, I had to record the screen to be able to take screenshots.

@stale stale bot removed the wontfix label Apr 2, 2024
@castillo92
Copy link

castillo92 commented Apr 2, 2024

I opened the web mobile in computer and could take the errors:

webui.js?v=430:1774 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'pendingStyleLoad')
    at Object.loadTorrents (webui.js?v=430:1774:16)
    at theWebUI.loadTorrents (<anonymous>:3567:22)
    at theWebUI.loadTorrents (<anonymous>:5452:22)
    at domUpdates (webui.js?v=430:1739:11)

loadTorrents @ webui.js?v=430:1774
theWebUI.loadTorrents @ VM615:3567
theWebUI.loadTorrents @ VM615:5452
domUpdates @ webui.js?v=430:1739
await in domUpdates (async)
(anonymous) @ webui.js?v=430:1741
#runTaskQueue @ backgroundtask.js:42
#scheduleRun @ backgroundtask.js:55
(anonymous) @ backgroundtask.js:89
#run @ backgroundtask.js:87
run @ backgroundtask.js:105
addTorrents @ webui.js?v=430:1743
theWebUI.addTorrents @ VM615:7132
theWebUI.addTorrents @ VM615:8393
(anonymous) @ rtorrent.js?v=430:1301
c @ jquery.js?v=430:2
fireWith @ jquery.js?v=430:2
l @ jquery.js?v=430:2
(anonymous) @ jquery.js?v=430:2
load (async)
send @ jquery.js?v=430:2
ajax @ jquery.js?v=430:2
Ajax @ rtorrent.js?v=430:1237
requestWithTimeout @ webui.js?v=430:2419
getTorrents @ webui.js?v=430:1613
update @ webui.js?v=430:2327
initFinish @ webui.js?v=430:377
loadPlugins @ webui.js?v=430:363
(anonymous) @ rtorrent.js?v=430:1301
c @ jquery.js?v=430:2
fireWith @ jquery.js?v=430:2
l @ jquery.js?v=430:2
(anonymous) @ jquery.js?v=430:2
load (async)
send @ jquery.js?v=430:2
ajax @ jquery.js?v=430:2
Ajax @ rtorrent.js?v=430:1237
requestWithoutTimeout @ webui.js?v=430:2424
getPlugins @ webui.js?v=430:338
init @ webui.js?v=430:248
(anonymous) @ webui.js?v=430:2567
Promise.then (async)
(anonymous) @ webui.js?v=430:2564
e @ jquery.js?v=430:2
t @ jquery.js?v=430:2
setTimeout (async)
(anonymous) @ jquery.js?v=430:2
c @ jquery.js?v=430:2
fireWith @ jquery.js?v=430:2
fire @ jquery.js?v=430:2
c @ jquery.js?v=430:2
fireWith @ jquery.js?v=430:2
ready @ jquery.js?v=430:2
P @ jquery.js?v=430:2
webui.js?v=430:2451 Uncaught TypeError: Cannot read properties of undefined (reading '-_-_-nlb-_-_-') from TypeError: Cannot read properties of undefined (reading '-_-_-nlb-_-_-')
    at <anonymous>:9888:169
    at Object.<anonymous> (https://myweb.com/rutorrent/js/rtorrent.js?v=430:1297:8)
    at c (https://myweb.com/rutorrent/js/jquery.js?v=430:2:25266)
    at Object.fireWith [as resolveWith] (https://myweb.com/rutorrent/js/jquery.js?v=430:2:26015)
    at l (https://myweb.com/rutorrent/js/jquery.js?v=430:2:77721)
    at XMLHttpRequest.<anonymous> (https://myweb.com/rutorrent/js/jquery.js?v=430:2:80204)
webui.js?v=430:2451 Uncaught TypeError: Cannot read properties of undefined (reading 'get') from TypeError: Cannot read properties of undefined (reading 'get')
    at plugin.updatedRSSEntry (<anonymous>:3639:46)
    at catlist.refreshPanel.prss (<anonymous>:3653:9)
    at CategoryList.refresh (https://myweb.com/rutorrent/js/category-list.js:463:35)
    at theWebUI.addRSSItems (<anonymous>:3761:10)
    at Object.<anonymous> (https://myweb.com/rutorrent/js/rtorrent.js?v=430:1301:22)
    at c (https://myweb.com/rutorrent/js/jquery.js?v=430:2:25266)
    at Object.fireWith [as resolveWith] (https://myweb.com/rutorrent/js/jquery.js?v=430:2:26015)
    at l (https://myweb.com/rutorrent/js/jquery.js?v=430:2:77721)
    at XMLHttpRequest.<anonymous> (https://myweb.com/rutorrent/js/jquery.js?v=430:2:80204)

@stickz
Copy link
Collaborator

stickz commented Apr 3, 2024

@castillo92 Please file a new issue report, so we can track the problem separately. The developer will need to make the plugin compatible. We rewrote the category list and panels to be more developer friendly.

@castillo92
Copy link

castillo92 commented Apr 7, 2024

@castillo92 Please file a new issue report, so we can track the problem separately. The developer will need to make the plugin compatible. We rewrote the category list and panels to be more developer friendly.

@stickz Thanks for the info, could be possible some day join Mobile plugin inside ruTorrent?

@xombiemp seems to have repaired the plugin by itself. I could not write until today, thanks to him!

In it's repo is the update: https://github.com/xombiemp/rutorrentMobile

Steps for new users:

# Official URL: https://github.com/xombiemp/rutorrentMobile
cd /var/www/rutorrent/plugins && sudo rm -R ipad
sudo git clone https://github.com/xombiemp/rutorrentMobile.git mobile
sudo chown www-data:www-data -R /var/www/rutorrent/plugins/mobile

# Enable plugin
Got to:	ruTorrent (WebUI) -> Plugins -> Mobile -> Lunch -> Enable

#To force load the plugin in a desktop browser add /?mobile=1 to the end of the rutorrent URL

@stickz
Copy link
Collaborator

stickz commented Apr 7, 2024

@xombiemp Would you like to distribute this plugin with ruTorrent? We can delete the Ipad plugin.
https://github.com/xombiemp/rutorrentMobile

My only request is to add a new tab in the settings menu for configuration and disable loading the mobile interface by default.

I'm more than happy to release a new ruTorrent v4.4 with this plugin. Just submit a pull request to develop and we'll get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants