Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofborg does not use $attr.meta.maintainers when $attr is in the commit message #668

Open
trofi opened this issue Dec 26, 2023 · 1 comment

Comments

@trofi
Copy link
Contributor

trofi commented Dec 26, 2023

Example PR: NixOS/nixpkgs#276696

There:

  1. nix_2_3 (or nixVersions.nix_2_3) was explicitly specified in commit message.
  2. nix repl agrees $attr.meta.maintainers does exist: nix-repl> nixVersions.nix_2_3.meta.maintainers => [ { ... } { ... } ]
  3. the PR does cause nixVersions.nix_2_3 rebuild

@lilyinstarlight says it's a side-effect of nixVersions.nix_2_3 defining most of it's relevant attributes in a file different from default.nix (common.nix). I suspect nix is not the only one doing it.

Proposal: extend ofborg to also handle direct $attr.meta.maintainers expand attributes right from the commit message (and possibly filter only on packages affected by the rebuild if reasonably feasible). I suspect that is what it does today to fetch tests and build the attribute.

@trofi
Copy link
Contributor Author

trofi commented Dec 26, 2023

NixOS/nixpkgs#276892 is another case where just following commit message attribute might be more desirable.

It's a no-op change from rebuild standpoint but I still would prefer maintainers to review that kind of change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant