Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers detected but not pinged? #636

Open
martinetd opened this issue Mar 13, 2023 · 2 comments
Open

maintainers detected but not pinged? #636

martinetd opened this issue Mar 13, 2023 · 2 comments

Comments

@martinetd
Copy link
Member

I'm curious why I wasn't pinged in this PR: NixOS/nixpkgs#211126 (as a pahole maintainer)

According to the ofborg-eval-check-maintainers action I was listed as a potential maintainer: https://gist.github.com/GrahamcOfBorg/03fefe23cc2d730a4ac58f66d28872ed
But I didn't receive any notification, nor see anything on the pull requests that'd hint I was mentioned.

Is there a limit to the maximum number of people being notified, or something like that?

@SuperSandro2000
Copy link
Member

Yes, GitHub only allows to ping 15 people

image

@martinetd
Copy link
Member Author

That's good to know... I only see 9 people in Cc on that ticket, but regardless of that particular limit would it be possible/make sense to just send a message with @ for people over the limit?

Rephrasing just to make sure I'm clear:

  • make list of maintainers as currently
  • only add people as maintainer like right now for the first x (not fussy on order, I assume there's already one)
  • add a comment Notifying extra maintainers involved: @alice @bob [...] for others

In most cases I assume that'd make no difference but it'd avoid having a surprise when something is broken after an upgrade a maintainer isn't even aware of, and that'd be appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants