Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tokenizers: fix cross build #307496

Merged
merged 1 commit into from Apr 29, 2024

Conversation

vytskalt
Copy link
Contributor

@vytskalt vytskalt commented Apr 28, 2024

Description of changes

Closes #307257
Based on #279145

Also was getting this error:

Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for tokenizers-0.19.1-cp311-cp311-linux_aarch64.whl
       >   - huggingface-hub not installed

which I fixed by adding huggingface-hub to propagatedBuildInputs dependencies

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Apr 28, 2024
@natsukium
Copy link
Member

@ofborg build pkgsCross.aarch64-multiplatform.python3Packages.tokenizers

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit d20c85b into NixOS:master Apr 29, 2024
25 of 26 checks passed
@vytskalt vytskalt deleted the tokenizers-fix branch April 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.tokenizers (cross compile to aarch64)
2 participants