Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'force HTTPS' switch not recognized when creating new (proxy) host #3737

Open
shakebox opened this issue May 3, 2024 · 1 comment
Open
Labels

Comments

@shakebox
Copy link

shakebox commented May 3, 2024

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • No, but creator of other image confirmed that issue should be an upstream issue
  • Are you sure you're not using someone else's docker image?
    • No, using other image, but issue seems to be upstream issue
  • Have you searched for similar issues (both open and closed)?
    • Yes

Describe the bug
When creating new (proxy, haven't tested others) host and you turn on the 'force HTTPS' switch, this setting will not be stored. You need to re-enable it manually by doing "edit" on the same host afterwards. Only then the activation of this switch is actually doing something!

Nginx Proxy Manager Version
2.11.1

To Reproduce
Steps to reproduce the behavior:

  1. press 'add proxy host'
  2. fill in the details and switch to the 'TLS' tab
  3. set the cert or set to 'request a new TLS certificate', then TURN ON the 'force HTTPS' button
  4. save and wait until you have new host created
  5. go to 'edit' for this newly created host
  6. go to TLS tab and see that the 'force HTTPS' button is NOT active

Expected behavior
when turning on any of the options switches while creating a new host, I'd expect it 'to do something' and not being ignored. For newbie users it may be dangerous because they may rely on the switch to behave as expected and never check the settings again after the initial creation.

Screenshots

Operating System
Ubuntu 22.04

Additional context
i was told from a fork user that it may be related to this:

if (!combined_data.certificate_id) {

as this is also called for new hosts and therefore the ssl_forced is always set to 'false'!?

@shakebox shakebox added the bug label May 3, 2024
@manilx
Copy link

manilx commented May 20, 2024

I have found the same issue. This has been fine on older versions, as I'm not adding new entries all the time I just found this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants