Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Bad Practices: Pickle Serialized Sessions #676

Open
QiAnXinCodeSafe opened this issue Jan 3, 2019 · 0 comments · May be fixed by #786
Open

Django Bad Practices: Pickle Serialized Sessions #676

QiAnXinCodeSafe opened this issue Jan 3, 2019 · 0 comments · May be fixed by #786

Comments

@QiAnXinCodeSafe
Copy link

Hi,
This is Qihoo360 CodeSafe Team, we found a Django Bad Practices: Pickle Serialized Sessions issue, see
neurovault/settings.py At line 219
image

If cookie-based sessions are used and SECRET_KEY is leaked, an attacker will be able to store arbitrary data in the session cookie which will be deserialized in the server leading to arbitrary code execution.
If cookie-based sessions are used, take extra care to make sure that the secret key is always kept completely secret, for any system which might be remotely accessible.
django.contrib.sessions.serializers.JSONSerializer is recommended.

Since I not familiar with NeuroVault, I hope you can look it

@rwblair rwblair linked a pull request Apr 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant