Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API documentation #752

Open
jdkent opened this issue Sep 26, 2022 · 3 comments
Open

Add API documentation #752

jdkent opened this issue Sep 26, 2022 · 3 comments
Labels
docs documentation related issues

Comments

@jdkent
Copy link
Contributor

jdkent commented Sep 26, 2022

Add embedded documentation about the API so the endpoints are explained/understandable.

@jdkent jdkent added the docs documentation related issues label Sep 26, 2022
@PeerHerholz
Copy link

PeerHerholz commented Sep 26, 2022

Currently there two python APIs available that, however, diverge in functionality and thus, as well as for housekeeping should be unified:

The work on this issue should/will include the following tasks:

  • list & evaluate functionality
  • decide on API package & integrate the other one into it
  • draft a first version of docs
  • include a set of examples

Work will be performed using a new environment, created via conda create -n pynv_test and then installing the respective packages.

@PeerHerholz
Copy link

pynv

  • installation via pypi works, results in 0.2
  • creation of collection (api.create_collection) & adding of an image (api.add_image) works
  • updating an existing image via api.update_image doesn't work (AttributeError: 'Client' object has no attribute 'update_image'
  • deleting an existing image or collection via api.delete_image/.delete_collection doesn't work (AttributeError: 'Client' object has no attribute 'delete_collection')
  • getting an existing collection via api.get_collection doesn't work (APIError: <h1>Server Error (500)</h1>)

@PeerHerholz
Copy link

pyneurovault

  • installation via pip + github works, results in 0.1.3.
  • dois_example.py works, thus obtaining all collections and wrangling the corresponding data
  • download_example.py appears to work, thus downloading and filtering
  • query_example.py doesn't work, some python 2/3 things and KeyError: 0 in images = get_images_with_collections(collection[0]["id"])[0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation related issues
Projects
Development

No branches or pull requests

2 participants