Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently the next argument is not invoked #18

Open
jhusain opened this issue Jun 17, 2015 · 3 comments
Open

Currently the next argument is not invoked #18

jhusain opened this issue Jun 17, 2015 · 3 comments

Comments

@jhusain
Copy link
Contributor

jhusain commented Jun 17, 2015

Every middleware function must invoke the next argument once it has finished its job. See this article: http://expressjs.com/guide/using-middleware.html

Note that when we handle a request we neglect to call the next parameter.

@jasonphillips
Copy link
Contributor

This was essentially handled back in 515e45c, right?

next() is now invoked on error from the datasource, and every other outcome is a res.send, which of course terminates the request and doesn't need to invoke next() at all. Unless I'm still missing something.

@ludovicthomas
Copy link

@jhusain As explained by @jasonphillips it has been resolved, but never published on NPM. Is it possible to publish the latest version please?
It's quite mandatory in order to get logs on the server about failures.
I'm adding @michaelbpaulson because he is the last one who has published on NPM.
Thanks

@blakeembrey
Copy link

blakeembrey commented Aug 31, 2016

Is someone planning to release this? I've been waiting months for the change personally, it really hinders development to not be able to debug errors properly. Most errors end up being output as { throwToNext: true }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants