Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 if invalid query string args #16

Open
jhusain opened this issue Jun 15, 2015 · 3 comments
Open

Return 400 if invalid query string args #16

jhusain opened this issue Jun 15, 2015 · 3 comments
Assignees
@ThePrimeagen

Comments

@jhusain
Copy link
Contributor

jhusain commented Jun 15, 2015

If any query string args are invalid, for example invalid JSON in path, we need to catch these errors and send back HTTP 400.
@ThePrimeagen
Copy link
Contributor

You must mean 500 correct?

Doh! of course, 400.

@mac-a1
Copy link

mac-a1 commented Jun 15, 2015

400 Bad Request seems appropriate for an invalid JSON path.

On Jun 15, 2015, at 3:11 PM, Michael Paulson notifications@github.com wrote:

You must mean 500 correct?

—
Reply to this email directly or view it on GitHub #16 (comment).

@jhusain
Copy link
Contributor Author

jhusain commented Jun 15, 2015

Yeah it was intentional.

JH

On Jun 15, 2015, at 3:19 PM, mac-a1 notifications@github.com wrote:

400 Bad Request seems appropriate for an invalid JSON path.

On Jun 15, 2015, at 3:11 PM, Michael Paulson notifications@github.com wrote:

You must mean 500 correct?

—
Reply to this email directly or view it on GitHub #16 (comment).

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThePrimeagen ThePrimeagen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhusain @ThePrimeagen @mac-a1