Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all coverage files (*.ec) included in the JacocoReport when using clearPackageData #83

Open
EverydayPineapple opened this issue May 2, 2023 · 3 comments
Open

Not all coverage files (*.ec) included in the JacocoReport when using clearPackageData #83

EverydayPineapple opened this issue May 2, 2023 · 3 comments
Labels
cantfix (bug in Android tooling) Some bugs cannot be fixed in plugin as the root cause is in the Android Tooling, Gradle, JaCoCo etc.

Comments

@EverydayPineapple
Copy link

Our project is setup in a way that outputs seperate .ec files per test. I believe this is due to the clearPackageData option being set to true, which is desired for us since it helps with test indempotence.

The issue is that the plugin is only looking for coverage.ec files when I need it to be looking for *.ec files.

The issue has been discussed here but I'm making a new issue since I'm not convinced that PR is trying to solve the same thing.
@Rolf-Smit Rolf-Smit mentioned this issue May 6, 2023
Closed
@Rolf-Smit
Copy link
Contributor

This is indeed something I never tested with this plugin, I have some more important bugs to work on first such as supporting the Android Gradle Plugin version 8.0. But this is on my radar as an improvement.

@Rolf-Smit Rolf-Smit changed the title Support for multiple .ec files Not all coverage files (*.ec) included in the JacocoReport when using clearPackageData May 6, 2023
@Rolf-Smit Rolf-Smit added the investigation required Bug for which is not yet certain what the root cause is label May 6, 2023
@Rolf-Smit
Copy link
Contributor

So I added a test case to the plugin (locally not pushed yet) that uses clearPackageData however I cannot reproduce the issue.

Do you remember which version of the plugin you where using? Gradle Managed Devices? Test Orchestration?

@Rolf-Smit
Copy link
Contributor

Rolf-Smit commented Nov 9, 2023 •
edited

Did some more testing and included Test Orchestrator into the mix, now I can reproduce the issue.

I took this configuration as example: https://github.com/android/testing-samples/blob/main/runner/AndroidTestOrchestratorWithTestCoverageSample/app/build.gradle

The bad news, this is not something I can fix as it seems to be a bug in the Android tooling itself:

The problem is that the coverage files that this Plugin needs (JaCoCo eventually needs them) are not created or disappear before we can use them.

Edit: pushed branch with a test case, that currently fails (but as explained not something that this plugin can fix)

Rolf-Smit added a commit that referenced this issue Nov 9, 2023
@Rolf-Smit
Add: test to verify if coverage is created with clearPackageData se…
c908e95 
…t to `true`

Turns out this test does not succeed, but this seems to be a bug in the Android Tooling and not something this plugin can solve.

See: #83
@Rolf-Smit Rolf-Smit added cantfix (bug in Android tooling) Some bugs cannot be fixed in plugin as the root cause is in the Android Tooling, Gradle, JaCoCo etc. and removed investigation required Bug for which is not yet certain what the root cause is labels Nov 9, 2023
Rolf-Smit added a commit that referenced this issue Nov 9, 2023
@Rolf-Smit
Add: test to verify if coverage is created with clearPackageData se…
4a24342 
…t to `true`

Turns out this test does not succeed, but this seems to be a bug in the Android Tooling and not something this plugin can solve.

See: #83
Rolf-Smit added a commit that referenced this issue Nov 10, 2023
@Rolf-Smit
Add: test to verify if coverage is created with clearPackageData se…
331dc6a 
…t to `true`

Turns out this test does not succeed, but this seems to be a bug in the Android Tooling and not something this plugin can solve.

See: #83
Rolf-Smit added a commit that referenced this issue Nov 10, 2023
@Rolf-Smit
Add: test to verify if coverage is created with clearPackageData se…
3c4a69c 
…t to `true`

Turns out this test does not succeed, but this seems to be a bug in the Android Tooling and not something this plugin can solve.

See: #83
@Rolf-Smit Rolf-Smit mentioned this issue Apr 10, 2024
Merged
Rolf-Smit added a commit that referenced this issue Apr 10, 2024
@Rolf-Smit
Add: test to verify if coverage is created with `clearPackageData=tru…
1b5d654 
…e` (#96)

Turns out this test does not succeed, but this seems to be a bug in the Android Tooling and not something this plugin can solve.

See: #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cantfix (bug in Android tooling) Some bugs cannot be fixed in plugin as the root cause is in the Android Tooling, Gradle, JaCoCo etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rolf-Smit @EverydayPineapple