Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window bash scripts (powershell) #319

Open
Nazariglez opened this issue Feb 27, 2024 · 5 comments
Open

Window bash scripts (powershell) #319

Nazariglez opened this issue Feb 27, 2024 · 5 comments

Comments

@Nazariglez
Copy link
Owner

I think that we should try to find a way to avoid the duplication of the scripts inside the scripts folder. I am not a big Windows user, I always work under UNIX (macOS and sometimes Linux), and I only test the examples or projects manually on Windows from time to time, that's why I did not think about porting the scripts to Windows (as @Rzial did here).

I worry that the window's script gets outdated fast, mainly because I may forget to update them along with the bash scripts. So I would like to explore other options, maybe we should get rid of the bash/ps scripts and use a common language in both systems like Python?

It seems that projects like tauri use Bash and PowerShell scripts as we do now, others like bevy only use bash, while egui uses a mix of bash and python scripts for different things.

What do you think @Rzial? I would like to hear opinions from Window's users. Thanks!

@Rzial
Copy link
Collaborator

Rzial commented Feb 27, 2024

Seems something legit, I can take a look on it.

Just to add some things to the table what do you think about a "rust-on-rust" solution?
Maybe using the 'cargo' crate to do something alimented by a toml that allows to do this.

We could also use Python 3 since is an inherited dependency to build on notan.

I'm just thinking out loud.

@Nazariglez
Copy link
Owner Author

Nazariglez commented Mar 1, 2024

Just to add some things to the table what do you think about a "rust-on-rust" solution?
Maybe using the 'cargo' crate to do something alimented by a toml that allows to do this.

Do you have any candidates in mind? I was looking at cargo script but it seems outdated and it requires the installation of an additional plugin. Then xshell looks interesting too, however, I am not sure how we can execute the scripts, do we need a new package to run the scripts?

I am inclined towards the frictionless path, if we can avoid requiring more deps and is easy to execute I am fine. That's why I thought of python because is pretty similar to bash and is probably installed already on most machines. The downside is that the scripts are in another language yeah. But I am open to suggestions ofc!

@xLin7648
Copy link

Git Bash https://git-scm.com/downloads

@Rzial
Copy link
Collaborator

Rzial commented Mar 19, 2024

While Git Bash could be handy using the original sh files I would rather prefer to have an approach that doesnt add more dependencies to the current stack.

Current project dependencies can manage this issue.

I'm still working on it but didn't found time to prepare and present a proper PR 😅

@Nazariglez
Copy link
Owner Author

Anything that makes window's user life easier makes sense to me. I am open to anything. What are your thoughts about https://github.com/matklad/cargo-xtask? it seems to be used on projects like zellij, rust-analyzer, and even cargo itself!

It looks very interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants