Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TermOffsetPopulator isn't clear state properly #2239

Open
d-hwang opened this issue Jan 30, 2024 · 0 comments
Open

TermOffsetPopulator isn't clear state properly #2239

d-hwang opened this issue Jan 30, 2024 · 0 comments
Assignees
@d-hwang

Comments

@d-hwang
Copy link
Collaborator

d-hwang commented Jan 30, 2024

When the 2nd hit in the same range doesn't have any content functions to evaluate, we aren't clearing the collected state/document for the subsequent record which can lead to invalid result.
@d-hwang d-hwang self-assigned this Jan 30, 2024
d-hwang added a commit that referenced this issue Jan 30, 2024
@d-hwang
re #2239: clear the document before exiting the method. empty keys ar…
3962dc1 
…e expected in some cases
@d-hwang d-hwang mentioned this issue Jan 30, 2024
Closed
d-hwang added a commit that referenced this issue Jan 30, 2024
@d-hwang
re #2239: clear the document before exiting the method. empty keys ar…
6468b22 
…e expected in some cases
hgklohr pushed a commit that referenced this issue Jan 31, 2024
@d-hwang @apmoriarty
re #2239: clear the document before exiting the method. (#2240)
d3bfb12 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
hgklohr pushed a commit that referenced this issue Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
a3b53eb 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
hgklohr pushed a commit that referenced this issue Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
4821b43 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
hgklohr pushed a commit that referenced this issue Feb 2, 2024
@d-hwang @apmoriarty @hgklohr
re #2239: clear the document before exiting the method. (#2240)
cc66916 
* re #2239: clear the document before exiting the method. empty keys are expected in some cases

* Add unit test for TermOffsetPopulator

---------

Co-authored-by: Moriarty <22225248+apmoriarty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-hwang d-hwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d-hwang