Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 5.1.x update missing @angular/service-worker/build/gulp #478

Open
garrettH3S opened this issue Jan 4, 2018 · 4 comments
Open

Angular 5.1.x update missing @angular/service-worker/build/gulp #478

garrettH3S opened this issue Jan 4, 2018 · 4 comments

Comments

@garrettH3S
Copy link

This module no longer contains this method. How can I update this file to work with angular 5.1.x?

import { gulpAddStaticFiles } from '@angular/service-worker/build/gulp';

@m-abs
Copy link
Collaborator

m-abs commented Jan 15, 2018

Did you find a solution? I'm having the same problem?

@m-abs
Copy link
Collaborator

m-abs commented Jan 15, 2018

I'm answering myself:
I downloaded https://github.com/angular/mobile-toolkit/blob/master/service-worker/worker/src/build/gulp.ts placed it in tools/utils, made a few minor fixes to make typescript accept it.

@garrettH3S
Copy link
Author

garrettH3S commented Jan 15, 2018

@m-abs I haven't found a solution yes. I removed the gulp job in the interim, I assume you cloned the mobile-toolkit down and imported it?

@m-abs
Copy link
Collaborator

m-abs commented Jan 15, 2018

Yes, just that one file. Typescript complaint about a few things, that I fixed.

I probably could just have deleted the task, we don't use service-workers (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants