Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length limits for feedback form #1566

Open
osma opened this issue Dec 5, 2023 · 0 comments
Open

Length limits for feedback form #1566

osma opened this issue Dec 5, 2023 · 0 comments

Comments

@osma
Copy link
Member

osma commented Dec 5, 2023

Description of the enhancement

There should be limits to the length of data processed by the feedback form, for example to combat DoS attacks.

This was already implemented for Skosmos 2.x in PR #1557 by @rvdwxl, but in that PR the limits for the "name", "email", and "subject" fields were hardcoded to 255 characters. Maybe the limit could be even shorter and perhaps configurable? And what about the main textarea, should its length be limited as well?

Who are the users that would benefit from the enhancement and how?

See #1557 - apparently there is a need for this since a PR was contributed by ArchiXL.

What new functionalities would the enhancement make possible?

Better security and robustness

Why is the enhancement important?

Security and robustness are important.

@osma osma added this to the 3.0 milestone Dec 5, 2023
@osma osma added this to Proposed Skosmos 3.0 issues (to do) in Skosmos 3.0 Backlog via automation Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Skosmos 3.0 Backlog
  
Proposed Skosmos 3.0 issues (to do)
Development

No branches or pull requests

1 participant