Switching language breaks ?uri= request parameter

[plecor]

URL address of the page where you encountered the problem

https://finto.fi/afo/fi/page/?uri=http://www.yso.fi/onto/afo/ for instance

Description of the problem

• go to https://finto.fi/afo/fi/page/?uri=http://www.yso.fi/onto/afo/
• click on 'in English' in top bar
• get result "404 Error: The page /afo/en/page/?uri=http//www.yso.fi/onto/afo/ cannot be found."

Additional information (e.g. screenshots) about the problem

When switching language, the uri parameter changes from uri=http://www.yso.fi/onto/afo/ to uri=http//www.yso.fi/onto/afo/ (the :after http is missing).

I believe this is related to

Skosmos/model/Request.php

Line 212 in dc900c3

$langurl = str_replace(":", "", $langurl);

Going directly to https://finto.fi/afo/en/page/?uri=http://www.yso.fi/onto/afo/ with a : does work.

[osma]

Thanks for the report @plecor !

May I ask how you arrived at the URL https://finto.fi/afo/fi/page/?uri=http://www.yso.fi/onto/afo/ ? Did you get there through some link generated by Skosmos or did you construct this yourself?

There's a problem with this URL that it doesn't URL encode the value of the uri parameter. The URL is thus invalid, but it happens to work anyway - with the exception of the language switching links as you noticed. The correct URL for this page would be https://finto.fi/afo/fi/page/?uri=http%3A%2F%2Fwww.yso.fi%2Fonto%2Fafo%2F which looks a bit uglier but the value of uri is properly encoded. In my understanding, links generated by Skosmos that use the uri parameter should always URL encode the values, but that may not always be the case, there could be a bug somewhere.

[plecor]

I did indeed construct myself https://finto.fi/afo/fi/page/?uri=http://www.yso.fi/onto/afo/ as an example to mimic our internal setup and its result - but your answer makes me think the issue is on our side.

We followed the example in the doc but we are not using Apache. We likely need to explicitely encode the parameter on our end.

Thanks a lot for your answer.