New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where should images/videos go? Assets, public? somewhere else? #115
Comments
Currently seems to work -- if anyone has an example where putting assets in |
Closing the issue for now until proven this is a problem -- if someone has a new example I'll happily debug it. |
Discussed with @emilyliquin and @guydav, we think the issue is when the image paths are string templates like One solution is to put stuff in Maybe add this to docs, at very least. |
I think we should implement this design pattern in an example somewhere (after making sure it actually works) and reference in the documentation: function getImageUrl(name) {
return new URL(`./dir/${name}.png`, import.meta.url).href
} @rhezab maybe we should try it with your experiment? |
Agree with Guy, I'll test this out and then add a note about this to the documentation if this works. |
I think @pclittle is about to go deep on exactly this issue because he has an experiment with a lot of videos that might need to preload so good chance to give him a recommendation and try it out! |
I’m fairly sure the answer is assets with some preloading — happy to look at it with you @pclittleTypo’d from my iPhoneOn Apr 20, 2024, at 00:11, Todd Gureckis ***@***.***> wrote:
I think @pclittle is about to go deep on exactly this issue because he has an experiment with a lot of videos that might need to preload so good chance to give him a recommendation and try it out!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Images in assets don't seem to load on deployment (but work in dev mode)
The text was updated successfully, but these errors were encountered: