Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Wrong count of number of outliers and whitelisted outliers #580

Open
maximilienroberti opened this issue Aug 17, 2020 · 0 comments
Open
Assignees

Comments

@maximilienroberti
Copy link
Contributor

If you observe the function process_outlier() in analyzer.py you can see that self.total_outliers is incremented event if the outlier is whitelisted.
https://github.com/NVISO-BE/ee-outliers/blob/58021dc20f6cbbe411c0a6337ea39a82fc139a9d/app/helpers/analyzer.py#L220-L235
Also, I observed that the number of whitelisted outliers represented by the variable 'self.nr_whitelisted_elements' is never incremented in that function. As a result, it does not count the number of whitelisted outliers in simplequery, word2vec and sudden_appearance models.

@maximilienroberti maximilienroberti self-assigned this Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant