Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Delete unncessary unittests #1781

Open
bschifferer opened this issue Mar 15, 2023 · 1 comment
Open

[Task] Delete unncessary unittests #1781

bschifferer opened this issue Mar 15, 2023 · 1 comment
Assignees
@viswa-nvidia
Labels
ci

Comments

@bschifferer
Copy link
Contributor

What needs doing
Originally, NVTabular contains code for models, layers and dataloader. We moved multiple features into separate repository. It seems that NVtabular contains unittests for certain features.

For example:
https://github.com/NVIDIA-Merlin/NVTabular/blob/main/tests/unit/loader/test_tf_dataloader.py#L401

https://github.com/NVIDIA-Merlin/dataloader/blob/main/tests/unit/dataloader/test_tf_dataloader.py#L416
@bschifferer bschifferer added the ci label Mar 15, 2023
@bschifferer
Copy link
Contributor Author

@viswa-nvidia can we plan it for 23.04 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viswa-nvidia viswa-nvidia

Labels
ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bschifferer @viswa-nvidia