Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITMDrvr does not check for failure to load ITM_AREA_CR_Ex from the ITM DLL #11

Open
aromanielloNTIA opened this issue Jan 18, 2024 · 0 comments · May be fixed by #13
Open

ITMDrvr does not check for failure to load ITM_AREA_CR_Ex from the ITM DLL #11

aromanielloNTIA opened this issue Jan 18, 2024 · 0 comments · May be fixed by #13
Labels
bug Something isn't working driver Issue relates to the ITM driver

Comments

@aromanielloNTIA
Copy link
Member

There is a typo here which causes the loading of ITM_AREA_TLS_Ex to be checked a second time, and causes no check to be performed on the loading of ITM_AREA_CR_Ex.

Most likely this would not cause real problems, since the correct error should already be returned in the case of a failure to load the first function, and the program should otherwise crash if an attempt is made to call the ITM_AREA_CR_Ex function after a failure to load it.

This does not impact the ITM DLL, just the ITMDrvr

@aromanielloNTIA aromanielloNTIA added the bug Something isn't working label Jan 18, 2024
@aromanielloNTIA aromanielloNTIA added the driver Issue relates to the ITM driver label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver Issue relates to the ITM driver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant