Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatteryStateful model not calculating replacements #828

Open
rohitkrishnanp opened this issue May 30, 2022 · 0 comments
Open

BatteryStateful model not calculating replacements #828

rohitkrishnanp opened this issue May 30, 2022 · 0 comments

Comments

@rohitkrishnanp
Copy link

Describe the bug
The battery stateful model of SAM doesn't compute the outputs n_replacements and indices_replaced even after giving the required replacement inputs replacement_option, replacement_capacity .

To Reproduce
Steps to reproduce the behavior:
Please run the simulation in the attached jupyter notebook ( rename from txt to ipynb , alternative is to create a script with required inputs and replacement options and run the calculation
battery_stateful bug.txt

Expected behavior
The replacement outputs should be calculated correctly

Additional context
After doing a static code analysis, I can see the runReplacement method of battery model is not called inside cmod_battery_stateful.cpp . This could be the reason why the replacements are not calculated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant