New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWH effective incidence angle relations are in terms of degrees #1030

Open

Matthew-Boyd opened this issue May 25, 2023 · 0 comments

Labels

bug

Contributor

Matthew-Boyd commented May 25, 2023 •

edited

These relations use degrees, not radians.

ssc/ssc/cmod_swh.cpp

Line 446 in f8d64af

    
           double theta_eff_diffuse = 59.7*M_PI / 180 - 0.1388*tilt*M_PI / 180 + 0.001497*tilt*M_PI / 180 * tilt*M_PI / 180;

ssc/ssc/cmod_swh.cpp

Line 456 in f8d64af

    
           double theta_eff_ground = 90 * M_PI / 180 - 0.5788*tilt*M_PI / 180 + 0.002693*tilt*M_PI / 180 * tilt*M_PI / 180;

Matthew-Boyd added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment