Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials printing results no longer works in development #470

Open
cdeline opened this issue Jul 20, 2023 · 1 comment
Open

Tutorials printing results no longer works in development #470

cdeline opened this issue Jul 20, 2023 · 1 comment
Assignees
Labels
v0_5_0 Include for v0.5.0 release

Comments

@cdeline
Copy link
Contributor

cdeline commented Jul 20, 2023

Starting in development branch, we are no longer aggregating bifacial gain in the top level Radiance Obj. This is now being recorded in the TrackerDict. This causes a lot of the outputs to fail, like when calling print('Accumulated hourly bifi gain for all the trackerdict: {:0.3}'.format(sum(demo.Wm2Back) / sum(demo.Wm2Front))).

At a minimum we should update notebooks in development to have functional print statements of results. Would this best be done with demo.calculateResults? It would be good to have some convenience functions in AnalysisObj that would make it easier to get at some of these values. It's a pain to have to go five levels deep like print(results['2021-01-14_1200']['Results'][0]['AnalysisObj'].backRatio). Maybe I'm just being dense here.

@cdeline cdeline added the v0_5_0 Include for v0.5.0 release label Jul 20, 2023
@cdeline cdeline self-assigned this Jul 20, 2023
@shirubana
Copy link
Member

demo.calculateResults saves a dataframe with all of the results, and also cleans it. The issue with that original way of calculating bifacial gain is that it did not clean for torqhetube, sky or ground or wrong material hitted by the rays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0_5_0 Include for v0.5.0 release
Projects
None yet
Development

No branches or pull requests

2 participants