Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHP Cost Curve Fix for ton-based rebates #273

Open
Bill-Becker opened this issue Sep 27, 2023 · 0 comments
Open

GHP Cost Curve Fix for ton-based rebates #273

Bill-Becker opened this issue Sep 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Bill-Becker
Copy link
Collaborator

The ITC and MACRS were not getting applied to the GHX and other non-heat-pump components, so as a workaround to shift the bug into a much less used component (rebates based on heat pump tonnage), all of the cost was lumped into the heat pump capacity-based term of the 2 term cost curve. So currently the rebates will be overestimating savings because they will apply to all GHP and GHX, etc components. To fix this for the long term solution, we need to migrate this function from the API and other related changes from that commit to separately apply the %-based incentives like ITC, and MACRS to the y-intercept term for GHX, etc components:

https://github.com/NREL/REopt_API/blame/c971e014bff491d4b665af308f7c7a207dc9f0ff/reo/src/data_manager.py#L320

@Bill-Becker Bill-Becker self-assigned this Sep 27, 2023
@Bill-Becker Bill-Becker added the bug Something isn't working label Sep 27, 2023
@Bill-Becker Bill-Becker changed the title GHP Cost Curve Fix GHP Cost Curve Fix for ton-based rebates Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant