Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AspNetBufferingTargetWrapper should not depend on NLogHttpModule #911

Open
snakefoot opened this issue Dec 28, 2022 · 1 comment
Open

AspNetBufferingTargetWrapper should not depend on NLogHttpModule #911

snakefoot opened this issue Dec 28, 2022 · 1 comment
Labels
ASP.NET 4 ASP.NET MVC Classic breaking change
Milestone
6.0

Comments

@snakefoot
Copy link
Contributor

Instead of depending on the static EventHandler in NLogHttpModule, then a dedicated NLogBufferingTargetWrapperModule should be introduced.

This will make unit-testing easier, and remove the noise in AspNetBufferingTargetWrapper InitializeTarget / CloseTarget-methods.
@snakefoot snakefoot added this to the 6.0 milestone Dec 28, 2022
@snakefoot snakefoot added the ASP.NET 4 ASP.NET MVC Classic label Dec 29, 2022
@bakgerman
Copy link
Contributor

bakgerman commented Aug 6, 2023 •
edited

Completed this in a branch until ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASP.NET 4 ASP.NET MVC Classic breaking change
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@bakgerman @snakefoot