Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:card): use skeleton instead to card-loading-content #8528

Merged
merged 1 commit into from May 20, 2024
Merged

fix(module:card): use skeleton instead to card-loading-content #8528

merged 1 commit into from May 20, 2024

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Apr 30, 2024 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8518

image

What is the new behavior?

In the latest antd 4, card-loading-content no longer exists and is replaced by the skeleton.

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@HyperLife1119 HyperLife1119 linked an issue Apr 30, 2024 that may be closed by this pull request
nzLoading is not working with nz-card on v17.4.0 #8518
Closed
@HyperLife1119 HyperLife1119 self-assigned this Apr 30, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (81ef077) to head (033a43c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8528      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      532       -1     
  Lines       18336    18333       -3     
  Branches     2801     2801              
==========================================
- Hits        16792    16789       -3     
  Misses       1226     1226              
  Partials      318      318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Laffery
Laffery approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM :)
ant design uses skeleton as well
image

@OriginRing OriginRing merged commit a36ebd3 into NG-ZORRO:master May 20, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriginRing OriginRing OriginRing approved these changes

@Laffery Laffery Laffery approved these changes

@vthinkxie vthinkxie Awaiting requested review from vthinkxie vthinkxie is a code owner

Assignees

@HyperLife1119 HyperLife1119

Labels
Component: Card PR: reviewed-approved PR: target-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nzLoading is not working with nz-card on v17.4.0
3 participants
@HyperLife1119 @OriginRing @Laffery