Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vec4.toString() should not be final #268

Open
jonbarril opened this issue Jun 20, 2023 · 0 comments
Open

Vec4.toString() should not be final #268

jonbarril opened this issue Jun 20, 2023 · 0 comments

Comments

@jonbarril
Copy link

I dare say that toString() in any class should not be final as extensions based on such classes can never implement their own toString() with whatever formatting the subclass may need.

In the specific case of Vec4, to utilize WorldWind as a platform, Vec4 parameters are required. However, it is nice to be able to extend Vec4, which lacks certain tech/math niceties, and to do a better job of compact formatted printing. There are work arounds but not making toString() final is by far the simplest solution and was probably done originally in 2013 out of habit.

--jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant