Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile Pose Position 3dfPoint and other Orientation or 3d space data objects #1363

Open
supertick opened this issue Nov 15, 2023 · 0 comments

Comments

@supertick
Copy link
Contributor

https://github.com/MyRobotLab/myrobotlab/pull/1336/files#diff-4183393faaeae629eb448cc3c8585057c1deb12f4e44c6564dfddae8b4027f42R3

kwatters

why , yet another point class? what about roll,pitch & yaw?

Member
Author
supertick

I could reuse Point3f I suppose

Member
AutonomicPerfectionist •
edited

There's also org.myrobotlab.kinematics.Point, and for roll, pitch, and yaw there's org.myrobotlab.service.data.Orientation

Really, all of these should be consolidated into one hierarchy at some point, with a Point specifying only coordinates, an Orientation specifying only rotational values, and Position containing both a Point marking its origin and an Orientation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant