MVVMCross 8.0.2 Android 12 support?

[kenneththorman]

We have an MVVMCross 8.0.2 application with a splash screen. Android 12 have made quite significant changes to the Splashscreen behaviour. We are facing some strange behaviors in relation to the IoC container that seems to not be initialized properly. This is initialized in the splash screen. When debugging it does seem like everything is being instantiated as it should, but we are faced with exceptions where it complains about null reference exceptions.

Does MVVMCross 8.0.2 at all support Android 12 ?

I am trying to figure out if this is just us not having handled Android 12 splash screen changes or if there is something fundamentally wrong in MVVMCross 8.0.2 in relation to Android 12.

[entdark]

Probably related to: #4290
That change was not released yet.
How do you use splash screen at all?
Does it work fine if you target Android 11?

[kenneththorman]

Some exceptions from logcat

07-06 10:33:47.838 30676 30676 E AndroidRuntime: FATAL EXCEPTION: main
07-06 10:33:47.838 30676 30676 E AndroidRuntime: Process: appinux.android, PID: 30676
07-06 10:33:47.838 30676 30676 E AndroidRuntime: android.runtime.JavaProxyThrowable: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> MvvmCross.Exceptions.MvxException: Failed to construct and initialize ViewModel for type DialogEvent.Common.ViewModels.SettingsViewModel from locator MvxDefaultViewModelLocator - check InnerException for more information ---> MvvmCross.Exceptions.MvxException: Problem creating viewModel of type SettingsViewModel ---> MvvmCross.Exceptions.MvxIoCResolveException: Failed to construct SettingsViewModel ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> Java.Lang.RuntimeException: Need android.permission.BLUETOOTH_CONNECT permission for AttributionSource { uid = 10458, packageName = appinux.android, attributionTag = null, token = android.os.BinderProxy@abdbe39, next = null }: AdapterService getBondedDevices
07-06 10:33:47.838 30676 30676 E AndroidRuntime:   at Java.Interop.JniEnvironment+InstanceMethods.CallObjectMethod (Java.Interop.JniObjectReference instance, Java.Interop.JniMethodInfo method, Java.Interop.JniArgumentValue* args) [0x0006e] in <0bcb31e97f7943a89bff9a1df2f35fa7>:0 
07-06 10:33:47.838 30676 30676 E AndroidRuntime:   at Java.Interop.JniPeerMembers+JniInstanceMethods.InvokeAbstractObjectMethod (System.String encodedMember, Java.Interop.IJavaPeerable self, Java.Interop.JniArgumentValue* parameters) [0x00014] in <0bcb31e97f7943a89bff9a1df2f35fa7>:0 
07-06 10:33:47.838 30676 30676 E AndroidRuntime:   at Android.Bluetooth.BluetoothAdapter.get_BondedDevices () [0x0000a] in <f1e8849d8b9c4b35af0f93902eb04475>:0 
07-06 10:33:47.838 30676 30676 E AndroidRuntime:   at DialogEvent.BluetoothPlugin.Droid.DroidBluetoothSerialDeviceFinder.get_Devices () [0x00000] in <5e165529aba043d18faf29072fbdd761>:0 

[Cheesebaron]

So first clue. Something is blowing up in your SettingsViewModel constructor:

07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at Android.Bluetooth.BluetoothAdapter.get_BondedDevices () [0x0000a] in <f1e8849d8b9c4b35af0f93902eb04475>:0 
07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at DialogEvent.BluetoothPlugin.Droid.DroidBluetoothSerialDeviceFinder.get_Devices () [0x00000] in <5e165529aba043d18faf29072fbdd761>:0 
07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at DialogEvent.Common.ViewModels.SettingsViewModel..ctor 

Have you set a breakpoint there and investigated what is up?

The other exception:

07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at DialogEvent.BluetoothPlugin.Droid.Plugin.Load () [0x001e0] in <5e165529aba043d18faf29072fbdd761>:0 
07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at MvvmCross.Plugin.MvxPluginManager.EnsurePluginLoaded (System.Type type, System.Boolean forceLoad) [0x00049] in <98d11a4865924e289a565575b5db9b59>:0 
07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at MvvmCross.Core.MvxSetup.LoadPlugins (MvvmCross.Plugin.IMvxPluginManager pluginManager) [0x0005d] in <98d11a4865924e289a565575b5db9b59>:0 

What happens in your Load method of that Bluetooth plugin?

[kenneththorman]

(DeviceFinders is the name we have given the Interface/Classes that are responsible for finding multiple different brands and devicetype of Bluetooth devices across protocols (SPP,HDP, BLE) and with differing communication rules )

BluetoothPlugin.Droid/Plugin.cs/Load()

       public void Load()
        {
            Mvx.IoCProvider.RegisterSingleton<IBluetoothDeviceFinderFactory>(new DroidBluetoothDeviceFinderFactory());
            Mvx.IoCProvider.RegisterSingleton<IBluetoothServiceFactory>(new DroidBluetoothServiceFactory());
            Mvx.IoCProvider.RegisterSingleton<IBluetoothHealthServiceFactory>(new BluetoothHealthServiceFactory());
            Mvx.IoCProvider.RegisterSingleton<IRequestBluetoothService>(new RequestBluetoothServiceDroid());

            // Since we have changed the devicefinder from a single deviceFinder to a List of deviceFinders, each UI should now be able to iterate through the list of deviceFinders.
            Mvx.IoCProvider.RegisterSingleton<IList<IDeviceFinder<IGlucometerDevice>>>(new List<IDeviceFinder<IGlucometerDevice>>
            {
                new MGHDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new CSGlucometerDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new CBLEDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>())
            });
            Mvx.IoCProvider.RegisterSingleton<IList<IDeviceFinder<IPulseSatDevice>>>(new List<IDeviceFinder<IPulseSatDevice>>
            {
                new NDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new NBLEDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new YBLEDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>())
            });
            Mvx.IoCProvider.RegisterSingleton<IList<IDeviceFinder<ISpirometerDevice>>>(new List<IDeviceFinder<ISpirometerDevice>>
            {

                //TODO collassare la logica finder tutta in ZephyrDeviceFinder?
                new ZLUNGDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new ZCOPDDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),

                new SMDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>())
            });

            Mvx.IoCProvider.RegisterSingleton<IList<IDeviceFinder<IWeightDevice>>>(new List<IDeviceFinder<IWeightDevice>>
            {
                new ADC355WeightDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new ADC351WeightDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new ADC352BLEDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>())
            });

            Mvx.IoCProvider.RegisterSingleton<IList<IDeviceFinder<IBPMDevice>>>(new List<IDeviceFinder<IBPMDevice>>
            {
                new ADBPMDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new ADA651BLEDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>()),
                new OBPMDeviceFinder(Mvx.IoCProvider.Resolve<IBluetoothDeviceFinderFactory>(), Mvx.IoCProvider.Resolve<IAppSettings>())
            });

            // here we customize what log level we want logs from the omron lib
#if DEBUG
            DebugLog.IsLoggableVerbose = false;
            DebugLog.IsLoggableDebug = true;
            DebugLog.IsLoggableInfo = true;
            DebugLog.IsLoggableWarn = true;
            DebugLog.IsLoggableError = true;
#endif
            Mvx.IoCProvider.Resolve<IMvxAndroidCurrentTopActivity>()?.Activity.RunOnUiThread(() =>
            {
                OPeripheralManager.SharedManager(Android.App.Application.Context).SetAPIKey("XXXXXXXXXXXXXXX", null);
            });
        }

[kenneththorman]

@Cheesebaron

Something is blowing up in your SettingsViewModel constructor:
It is not just the SettingsViewModel it seems to be most ViewModels on some Android 12 devices

SettingsViewModel()

public class SettingsViewModel : BaseViewModel
{
    private readonly IAppSettings _appSettings;
    private readonly IEventRepository _dbManager;
    private readonly INotificationDisplayer _notificationDisplayer;
    private readonly IBluetoothSerialDeviceFinder _bluetooth; 
    private readonly INotificationScheduler _notificationScheduler;
    private readonly ICOPDPersistence _copdPersistence;
    private readonly IStorage _storage;        
    private readonly ILoggingService _loggingService;
    private readonly ISyncDataService _syncDataService;
    private readonly IApplicationService _applicationService;
    private readonly IMvxNavigationService _navigationService;

    public SettingsViewModel(
        IMvxNavigationService navigationService, 
        IAppSettings appSettings, 
        IEventRepository dbManager, 
        INotificationScheduler notificationScheduler, 
        IReachabilityService reachabilityService, 
        ILanguageControl languageControl, 
        ICareSamlLoginFactory careSamlLoginFactory, 
        INotificationDisplayer notificationDisplayer, 
        ICOPDPersistence copdPersistence, 
        IStorage storage, 
        ISyncDataService syncDataService, 
        ILogger<SettingsViewModel> logger, 
        IBluetoothDeviceFinderFactory bluetooth = null
    ) : base(navigationService, reachabilityService, careSamlLoginFactory, appSettings, logger)
    {
        _navigationService = navigationService;
        _appSettings = appSettings;
        _dbManager = dbManager;
        _notificationScheduler = notificationScheduler;
        _notificationDisplayer = notificationDisplayer;
        _storage = storage;            
        _loggingService = Mvx.IoCProvider.GetSingleton<ILoggingService>();
        _syncDataService = syncDataService;
        _copdPersistence = copdPersistence;
        _applicationService = Mvx.IoCProvider.GetSingleton<IApplicationService>();
        if (bluetooth != null)
        {
            _bluetooth = bluetooth.CreateFinder();
            if(_bluetooth != null)
                _devices = _bluetooth.Devices;
        }                        
    }
// ...
}

base of SettingsViewModel

protected BaseViewModel(IMvxNavigationService navigationService, IReachabilityService reachabilityService, ICareSamlLoginFactory careSamlLoginFactory, IAppSettings appSettings, ILogger<BaseViewModel> logger)
{
    _navigationService = navigationService;
    _reachabilityService = reachabilityService;
    _careSamlLoginFactory = careSamlLoginFactory;
    _appSettings = appSettings;
    _autoLoginService = Mvx.IoCProvider.GetSingleton<IAutoLoginService>();
    _logger = logger;

    var _messenger = Mvx.IoCProvider.Resolve<IMvxMessenger>();
    _messenger.Subscribe<SocketOnlineMessage>((message) =>
    {
        _changeIconSignalling.Raise();
    }, MvxReference.Strong);

    _messenger.Subscribe<SocketOffLineMessage>((message) =>
    {
        _changeIconSignalling.Raise(false);
    }, MvxReference.Strong);

    _messenger.Subscribe<LogoutMessage>((message) =>
    {
        LogoutDueSessionExpired = true;

        DoLogout(true, message != null && message.ErrorCode == -1);
    }, MvxReference.Strong);

    _messenger.Subscribe<PinCodeMessage>((message) =>
    {
        if (this is ChooseDomainViewModel || this is PickLanguageViewModel)
            return;

        _pincodeInteraction.Raise();
    }, MvxReference.Strong);
}

[kenneththorman]

So first clue. Something is blowing up in your SettingsViewModel constructor:

07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at Android.Bluetooth.BluetoothAdapter.get_BondedDevices () [0x0000a] in <f1e8849d8b9c4b35af0f93902eb04475>:0 
07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at DialogEvent.BluetoothPlugin.Droid.DroidBluetoothSerialDeviceFinder.get_Devices () [0x00000] in <5e165529aba043d18faf29072fbdd761>:0 
07-07 12:33:57.858 16293 16293 E AndroidRuntime:   at DialogEvent.Common.ViewModels.SettingsViewModel..ctor 

Have you set a breakpoint there and investigated what is up?

The other exception:

07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at DialogEvent.BluetoothPlugin.Droid.Plugin.Load () [0x001e0] in <5e165529aba043d18faf29072fbdd761>:0 
07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at MvvmCross.Plugin.MvxPluginManager.EnsurePluginLoaded (System.Type type, System.Boolean forceLoad) [0x00049] in <98d11a4865924e289a565575b5db9b59>:0 
07-06 10:33:49.312 31212 31212 E AndroidRuntime:   at MvvmCross.Core.MvxSetup.LoadPlugins (MvvmCross.Plugin.IMvxPluginManager pluginManager) [0x0005d] in <98d11a4865924e289a565575b5db9b59>:0 

What happens in your Load method of that Bluetooth plugin?

@Cheesebaron You were on the right track. It pains me to say that we did not properly read the inner most exception message in logcat (partly because there is no line breaks and the relevant part starts at column 761).

The Appinux mobile app is integrating/using many different external Bluetooth devices.
These Bluetooth devices differ fundamentally in their approach to Bluetooth protocol, Bluetooth profile and communication protocol.
Android 12 introduced new Bluetooth permissions and this was what caused the problem.
The specific error is

Java.Lang.RuntimeException: Need android.permission.BLUETOOTH_CONNECT permission for AttributionSource

The strange part is that it does not seem to happen on all devices we have with Android 12.

Anyhow - it is not a MVVMCross problem. I am sorry to have taken up everyone's time, and a big thank you to all that have contributed.

Regards
Kenneth

[dinomov]

Here my device Samsung Galaxy 10S android 12. on this device I do not have any crash

[entdark]

Splash screen activity is a bad practice.
The best old practice is setting splash screen with app theme. Then in OnCreate of your activity change theme to main one.
The best new practice is: https://developer.android.com/guide/topics/ui/splash-screen

[DavidMarquezF]

So then I understand that the best practice would be to not have a dedicated Splash Activity? If that is the case how are we supposed to handle the MvvmCross initialization? Now it is handled by the MvxSplashScreenActivity but if we eliminate it I'm not really sure what would be the proper way of initializing it

[entdark]

Just remove it. Should work fine without it out of the box. Just set MainLauncher = true to your main activity.
MvvmCross gets initialized by itself. You should not call anything manually.