Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better way to display file sizes #25

Open
Munter opened this issue Sep 30, 2015 · 1 comment
Open

Figure out a better way to display file sizes #25

Munter opened this issue Sep 30, 2015 · 1 comment

Comments

@Munter
Copy link
Owner

Munter commented Sep 30, 2015

The current crazy bloated file size reporting is caused by the fact that you can never write more data to the read buffer than you originally said the file would contain in the stat operation.

During the stat operation the file might not be in cache, thus not have a valid file size.

The current hack I'm using is to report 1mb + 10 * file size to be sort of certain that a transpilation output won't be bigger than the stat operation said. Then I simply return an empty read callback while incrementally reading, which correctly stops the read operation from reading all the wrongly reported non-existent bytes.

It would be much better to have a way to simply show no file size and let the unknowns be unknowns. The problem is I haven't figured out a way to do this yet while still allowing file reads that are correct.

@Munter
Copy link
Owner Author

Munter commented Jul 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant