Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illumar buttons missing? #1856

Open
m-doescode opened this issue May 12, 2024 · 3 comments
Open

Illumar buttons missing? #1856

m-doescode opened this issue May 12, 2024 · 3 comments

Comments

@m-doescode
Copy link

m-doescode commented May 12, 2024

Minecraft version

1.19.x

CodeChickenLib version

4.3.2.490

CBMultipart version

3.2.0.139

ProjectRed version

4.17.0

What happened?

It seems like the illumar buttons have been removed from the code. Is there a reason for this? Will they ever be added back? (It's also worth noting that translations still exist for them in the lang files.

@m-doescode m-doescode added the bug label May 12, 2024
@m-doescode
Copy link
Author

I accidentally added the "bug" label because I used the template... I realize now this is better suited for the Discussion tab..

@MrTJP MrTJP added enhancement and removed bug labels May 12, 2024
@MrTJP
Copy link
Owner

MrTJP commented May 12, 2024

No problem. Fixed the labels.

Yea I have not gotten around to adding them back. I don't think i'll be bringing back the feedback buttons as there were problems with that implementation, but I'll reimplement the normal buttons soon.

@m-doescode
Copy link
Author

Makes sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants