Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framed wires/cables not rendering multiple passes of covers. #1697

Open
KitsuneAlex opened this issue Nov 22, 2021 · 3 comments
Open

Framed wires/cables not rendering multiple passes of covers. #1697

KitsuneAlex opened this issue Nov 22, 2021 · 3 comments
Labels

Comments

@KitsuneAlex
Copy link

Describe the bug
I've been working on CBM integration for my mod. It makes heavy use of the CCL rendering pipeline for it's own blocks so it was fairly easy to implement a multi-pass BlockMicroMaterial.
However, after testing my implementation for a bit, i realized that when i put a CBM cover on one of the framed wire/cable types from ProjectRed, it only renders the first pass of my micro material.
Because of that i assume that the cover rendering when already applied only renders the first pass in general, or rather only one RenderType.

I didn't make a PR for this because covers said parts of CBM (and therefore PR?) are gonna be rewritten anyways, especially regarding rendering, so i'm leaving this one to you.

To Reproduce
I am the only one able to reproduce this as of right now, since the mod isn't released yet.

Expected behavior
I am expecting the framed wires/cables to render all passes of a cover defined in it's BlockMicroMaterial.

Crash Log
No crash.

Versions

  • CCL Version: 4.0.4.436
  • CBM Version: 3.0.3.122
  • ProjectRed Version: 4.11.0-beta-0

Screenshots/Videos
The actual rendering when a cover is applied:
Image
How the covered part should look:

@MrTJP
Copy link
Owner

MrTJP commented Nov 22, 2021

Interesting. I’ll take a look. If I remember correctly, there was some logic to prevent rendering (or even applying) transparent materials to frames (because the underside wire is completely not rendered while there is a cover on it). I don’t recall any special handling of multi-layered micro materials.

@KitsuneAlex
Copy link
Author

Alright, i honestly didn't really look into it myself too much yet, but if i find anything i'll let you know. Just thought you might be able to spot the issue quicker than me :) Also thanks for the quick reply!

@covers1624
Copy link
Collaborator

@MrTJP discord :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants