Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug in PersistedData.isArray() #5069

Open
jdrueckert opened this issue Aug 21, 2022 · 2 comments
Open

Potential bug in PersistedData.isArray() #5069

jdrueckert opened this issue Aug 21, 2022 · 2 comments
Labels
Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@jdrueckert
Copy link
Member

jdrueckert commented Aug 21, 2022 •
edited

In #5062 it was noted, that for some reason the PersistedData for a JSON object returns true for isArray() - and not only for actual JSON arrays.

This issue was worked around in the PR by an additional check because a JSON object is also a "value map",

However, it is unclear whether this is specific to JSON or a bug in PersistedData...?
This should be investigated in more detail and potentially fixed in PersistedData
@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Aug 21, 2022
@jdrueckert jdrueckert mentioned this issue Aug 21, 2022
Merged
3 tasks
@soloturn
Copy link
Contributor

this is not a security issue, so close until it becomes a real bug :)

@jdrueckert
Copy link
Member Author

This is a potential bug that needs to be investigated further.
Most of our bugs are no security issues, but that doesn't mean they shouldn't be investigated and fixed.

@jdrueckert jdrueckert reopened this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Investigation Requires to be debugged or checked for feasibility, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soloturn @jdrueckert