removed net_avg parameter from model call and widget
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
reviewed
May 7, 2024
There was a problem hiding this comment.
I can merge this, but going forward, I think it might be time to put an "archived" or "unmaintained" notice on the readme here if @carsen-stringer also doesn't have time for this plugin.
I suspect they are putting their efforts into their own gui, which is understandable
| @@ -22,7 +22,7 @@ packages = find: | |||
| install_requires = | |||
| napari | |||
| napari-plugin-engine>=0.1.4 | |||
| cellpose>0.6.3 | |||
| cellpose>=3.0.7 | |||
There was a problem hiding this comment.
Given that nobody is watching this repo, you might consider a stricter pin here to avoid similar incompatibilities in the future
|
I guess the other option is to pin the other way, setting upper bound to the last cellpose 2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Dear maintainers @carsen-stringer @psobolewskiPhD
This PR
net_avgfrom the call to the cellpose model.>=3.0.7)I am not entirely sure when exactly
net_avgwas deprecated but didn't want to go back all the version to find it - hope that's okay :)