Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major design changes #14

Closed
wants to merge 0 commits into from
Closed

Conversation

piegamesde
Copy link

Fixes #13. Non-exhaustive list of changes:

  • Replaced all the printlns with proper logging
  • Replaced the command line with a new interface using a library (and also with a completely new design)
  • Dependency handling is now done through Maven
  • May not work with older versions of the Minecraft server anymore
  • Removed all of the bloat and unused stuff (update and download feature, time measurement etc.)
  • Simplified the server launch sequence (it is mostly the "alternate" one)
  • Made it more library-friendly
  • Added new generation mechanic using permanently loaded chunks (way faster)
  • Added JavaDocs and one unit test

@VADemon
Copy link

VADemon commented Jan 23, 2019

May not work with older versions of the Minecraft server anymore

Would be nice to keep it backwards-compatible, we are currently looking for an infdev/alpha pregenerator, this is the only accessible option.

(the other one is to rip out the chunk gen code)

@buchwasa
Copy link

Been unable to get this to work. Is this still a work in progress?

@piegamesde
Copy link
Author

piegamesde commented Apr 15, 2019

No, it's pretty much done feature-wise and I even use this to generate test world for another project. I just noticed that none of the documentation has been updated since all the changes were made. I'll do this soon™.

On the other hand: what have you tried and why didn't it work?


Edit: I just noticed some commits with bug fixes on the develop branch I forgot to merge, this may be the reason.

@buchwasa
Copy link

buchwasa commented Apr 15, 2019

@piegamesde I just tried running it and I get a getCallerClass error and shuts off right after.

Edit: Probably would help if I was compiling on Java 8 haha
Edit Edit: Compiling on Java 11 gives me the warning, and shuts off, compiling on Java 8 gives me nothing and shuts off.

@piegamesde
Copy link
Author

Since it seems that there are no plans to integrate our changes, we decided to continue the fork on our own: https://github.com/sommerlilie/MinecraftLandGenerator

@Wumpotamus Please create an issue there if it still doesn't work for you.

@piegamesde piegamesde closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major design changes
3 participants