Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing support #2777

Open
last-partizan opened this issue Nov 4, 2023 · 1 comment
Open

Typing support #2777

last-partizan opened this issue Nov 4, 2023 · 1 comment

Comments

@last-partizan
Copy link
Contributor

Hi folks

Are you interested in adding types to your project?

There is https://github.com/sbdchd/mongo-types project, but it's incomplete and outdated. But types can be integrated back into the original project.

If you're interested, i can try making a PR.

@bagerard
Copy link
Collaborator

This is a great idea but it all depends how much it will clutter this codebase. Although MongoEngine is way less complex and popular, it is worth mentioning this post from django on the same topic django/deps#65

I recently started testing mongo-types and fixed a bunch of issues, of course the dynamic nature of Documents, some Fields and Querysets makes typing quite tricky to get right, you may want to check it out here https://github.com/bagerard/mongo-types. I also see that the original project received some commits recently.

Alternative could be to get mongo-types under the MongoEngine umbrella, but as a separate library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants