-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required strings #600
Comments
Examples for feeds currently using (very few) empty station names:
|
This discussion has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Those examples are for virtual stations, so maybe they should be parking areas (geofencing zones)? |
Before opening a PR, I would like the opinion of the community:
Please give your feedback with 👍 👎 👀 :
My view: if a REQUIRED field should accept empty strings, maybe it shouldn't be REQUIRED. |
I agree with you I would argue that an empty string is never something you should put in a GBFS feed. It's either required or optional but empty is string kind of both, which seems like a modelling error. |
Fix MobilityData#600 https://mobilitydata-io.slack.com/archives/CNXA9ASBV/p1715598631556219 Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>
What is the issue and why is it an issue?
REQUIRED Strings : should the specification says they MUST NOT be empty (
""
) ?Please describe some potential solutions you have considered (even if they aren’t related to GBFS).
The specification could say either:
Is your potential solution a breaking change?
See also https://mobilitydata-io.slack.com/archives/CNXA9ASBV/p1708429919754579
The text was updated successfully, but these errors were encountered: