-
-
Notifications
You must be signed in to change notification settings - Fork 189
Consider adding postcss-flexbugs-fixes #158
Comments
For now it's ok since it only fix bug8, but some workarounds (bug3) may add rules and potentially can override user's rules. |
We might enhance this plugin so it add warnings about those potential collisions. |
and let the user select which bug the want to fix |
Oh! I forgot about that. I still have to publish the plugin to npm, but I'd like to add more rules before doing so. |
I'm just seeing this plugin for the first time, and I already see some problems with it. I filed luisrudge/postcss-flexbugs-fixes#18 and luisrudge/postcss-flexbugs-fixes#19. Assuming these are fixed I think it'd be OK to add, but my concern is it might make users think they don't have to worry about these issues at all anymore, when in fact many of them can only be solved in HTML-land. Also, some of them (e.g. 7) won't be able to catch all cases, arguably most cases even. Consider this example: * {
box-sizing: border-box;
}
.box {
flex: 1 1 50%;
padding: 1em;
} cssnext cannot always know what elements have their box model set to |
Yeah @philipwalton. I thought about that too. Most of the stuff are too context dependent, so you need to check html to see if that'll happen or not. One thing we discussed in an issue, is to emit warnings about other bugs, but I don't like that idea either. |
Good points guys. Warnings can help at least luisrudge/postcss-flexbugs-fixes#17 |
I don't think it's a good idea anymore. |
What do you think about that guys ?
https://github.com/luisrudge/postcss-flexbugs-fixes
Would be nice to have it ?
The text was updated successfully, but these errors were encountered: