Skip to content
This repository has been archived by the owner on Mar 18, 2019. It is now read-only.

Consider adding postcss-flexbugs-fixes #158

Closed
MoOx opened this issue Jun 19, 2015 · 8 comments
Closed

Consider adding postcss-flexbugs-fixes #158

MoOx opened this issue Jun 19, 2015 · 8 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Jun 19, 2015

What do you think about that guys ?

https://github.com/luisrudge/postcss-flexbugs-fixes

Would be nice to have it ?

@lionelB
Copy link
Contributor

lionelB commented Jun 19, 2015

For now it's ok since it only fix bug8, but some workarounds (bug3) may add rules and potentially can override user's rules.

@MoOx
Copy link
Owner Author

MoOx commented Jun 19, 2015

We might enhance this plugin so it add warnings about those potential collisions.
poke @luisrudge

@lionelB
Copy link
Contributor

lionelB commented Jun 19, 2015

and let the user select which bug the want to fix

@luisrudge
Copy link

Oh! I forgot about that. I still have to publish the plugin to npm, but I'd like to add more rules before doing so.

@philipwalton
Copy link

I'm just seeing this plugin for the first time, and I already see some problems with it. I filed luisrudge/postcss-flexbugs-fixes#18 and luisrudge/postcss-flexbugs-fixes#19.

Assuming these are fixed I think it'd be OK to add, but my concern is it might make users think they don't have to worry about these issues at all anymore, when in fact many of them can only be solved in HTML-land.

Also, some of them (e.g. 7) won't be able to catch all cases, arguably most cases even. Consider this example:

* {
  box-sizing: border-box;
}

.box {
  flex: 1 1 50%;
  padding: 1em;
}

cssnext cannot always know what elements have their box model set to border-box.

@luisrudge
Copy link

Yeah @philipwalton. I thought about that too. Most of the stuff are too context dependent, so you need to check html to see if that'll happen or not. One thing we discussed in an issue, is to emit warnings about other bugs, but I don't like that idea either.

@MoOx
Copy link
Owner Author

MoOx commented Jul 16, 2015

Good points guys.

Warnings can help at least luisrudge/postcss-flexbugs-fixes#17

@MoOx
Copy link
Owner Author

MoOx commented Aug 6, 2015

I don't think it's a good idea anymore.

@MoOx MoOx closed this as completed Aug 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants