Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency/Readme clean up #586

Open
Doom4535 opened this issue Jul 16, 2023 · 1 comment
Open

Dependency/Readme clean up #586

Doom4535 opened this issue Jul 16, 2023 · 1 comment

Comments

@Doom4535
Copy link

Assuming my quick check of the build dependencies is correct, could the main page be updated to reflect the current dependencies? It would help with cleaning up distro packages and could save build time for source build systems.

Deprecated dependencies

I believe the following libraries are no longer required for the latest builds:
ncurses (since v3 on, I believe the last usage was v2.1.0 NCursesOverlay.hpp, v2.1.0 CMakeLists.txt)
gflags (since v6 on, last usage was on v5, with removal here: #206)

Potentially optional dependencies:

boost When looking at the curent master 2e06248, I'm not seeing much usage of boost (most (or all) are checks to see if it is availible); when grep'ing through the v6 releases, I'm seeing a lot of references to it in the external and the more recent (since v6.0.4, but not in master; presumably for vcpkg) external_imported (different commit
5eb70c/external_imported) folders. Additionally, I am able to build a few random v6 releases without boost; what is lost by not including this library in a build and could the main page be updated to make this an optional include (with some details on why one may/may not want to include it (is this library currently included solely for vcpkg?))?

@MisterTea
Copy link
Owner

Thanks for looking into this! Boost Filesystem was used back when we had significant folks running older compilers without standard filesystem. We can probably remove it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants