Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: NetworkManager.exceptions advanced options #3607

Open
Paradoks-Studio opened this issue Sep 16, 2023 · 1 comment
Open

feature: NetworkManager.exceptions advanced options #3607

Paradoks-Studio opened this issue Sep 16, 2023 · 1 comment

Comments

@Paradoks-Studio
Copy link
Contributor

While we are at it, this feature request is related to this one:
#3605
My server is running in production since a few years now, and i noticed that sometimes logging exception can cost a lot on CPU and generate latency.
So i commented out the errors or transformed them into warnings or simple logs, and noticed that the lags they generated disapeared.

So the request, (don't know if it is worth performance wise, you will have to check ):
instead of making a bool like on #3605.
make an enum:
exceptionHandling:

  • Disconnect and log errror
  • Disconnect and log warning
  • Log errror
  • Log warning
  • Do nothing ( !! )
    Some exception don't generate disconnections, so they will be handeled by the 3 last.
@MrGadget1024
Copy link
Collaborator

@Paradoks-Studio A big part of the log cost is stacktrace - you can turn that off here at the bottom of Player Settings:

image

Additionally, on server you can change to Console.WriteLine instead of Debug.Log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants