Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all stored datetimes for timezones #503

Open
jonathanstegall opened this issue Oct 6, 2022 · 2 comments
Open

Check all stored datetimes for timezones #503

jonathanstegall opened this issue Oct 6, 2022 · 2 comments
Labels
enhancement New feature or request third party plugin problem This issue is about supporting a third party plugin

Comments

@jonathanstegall
Copy link
Member

Is your feature request related to a problem? Please describe.
I think it would be nice if all datetime values were stored in the database as UTC and then converted to local, but I don't think that is actually what happens.

To verify this:

  1. Set up the plugin in WordPress with a default (UTC) timezone. Turn on debug mode.
  2. Run Salesforce sync tasks
  3. Change the timezone to something local, ex Chicago.
  4. Try to run the same Salesforce sync tasks. For example a manual user push/pull from the user profile.
  5. See a log entry: "Notice: : Did not sync WordPress user with ID of whatever with Salesforce Id whatever because the last sync timestamp was greater than the object updated timestamp."
  6. Switch it back to UTC and repeat. Nothing prevents it from happening.

Describe the solution you'd like
I think it would be nice if all datetime values were stored in the database as UTC and then converted to local.

@jonathanstegall jonathanstegall added the enhancement New feature or request label Oct 6, 2022
@jonathanstegall
Copy link
Member Author

I'm not really sure what the backward compatibility of this would be. It would be nice if it didn't break anything, but that will need testing.

@jonathanstegall
Copy link
Member Author

Related issue: woocommerce/action-scheduler#765

@jonathanstegall jonathanstegall added the third party plugin problem This issue is about supporting a third party plugin label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request third party plugin problem This issue is about supporting a third party plugin
Projects
None yet
Development

No branches or pull requests

1 participant