Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to choose their desired date format in fieldmaps #276

Open
jonathanstegall opened this issue Jul 10, 2019 · 2 comments · May be fixed by #339
Open

Allow users to choose their desired date format in fieldmaps #276

jonathanstegall opened this issue Jul 10, 2019 · 2 comments · May be fixed by #339
Assignees
Labels
enhancement New feature or request in progress Work on this issue has started, but is not finished
Milestone

Comments

@jonathanstegall
Copy link
Member

Is your feature request related to a problem? Please describe.
Yes. Currently the plugin tries to use the default date format in WordPress whenever possible. This can cause issues though, especially with other plugins. Here's an example forum post on this.

Describe the solution you'd like
When mapping a field in the admin, if the plugin is able to detect that the field is a date field in Salesforce, we could expose a field for the date format. Users could then type in a valid PHP date format. From there, whenever the plugin tried to save data into WordPress, it would use that date format instead of the default WP format.

Describe alternatives you've considered
Currently this can be done with the object_sync_for_salesforce_push_params_modify hook, but there's no exposure in the admin for this problem.

@jonathanstegall jonathanstegall added the enhancement New feature or request label Jul 10, 2019
@jonathanstegall jonathanstegall added this to the v1.9.0 milestone Jul 22, 2019
@jonathanstegall
Copy link
Member Author

giving this a start with commits 7dc14c2, f6bc613, and 1466612.

@jonathanstegall jonathanstegall self-assigned this Oct 30, 2019
@jonathanstegall jonathanstegall added the in progress Work on this issue has started, but is not finished label Oct 30, 2019
@jonathanstegall
Copy link
Member Author

jonathanstegall commented Nov 13, 2019

In WordPress 5.3, dates got a lot of improvements, as mentioned in #327. Need to make sure that whatever we do takes advantage of this.

@jonathanstegall jonathanstegall modified the milestones: v1.9.0, 1.10.x, 1.10.0 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress Work on this issue has started, but is not finished
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant