Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text (or other icon?) fallbacks for Font Awesome icons #156

Open
jonathanstegall opened this issue Mar 18, 2021 · 2 comments
Open

Text (or other icon?) fallbacks for Font Awesome icons #156

jonathanstegall opened this issue Mar 18, 2021 · 2 comments
Labels

Comments

@jonathanstegall
Copy link
Member

Sometimes the Font Awesome API fails to respond. I think we should have a fallback for the icons that aren't already accompanied by text labels. For example the donate button has an icon, but it also has text so we don't have to worry as much about it.

But specifically the search icon, the account icon, the arrow nav icons, and the social icons do not currently have fallbacks if the icon API goes down.

As in the header nav:

image

@jonathanstegall
Copy link
Member Author

Maybe we could figure out if it's possible to use the SVG icons that are used in Gutenberg.

@jonathanstegall
Copy link
Member Author

We could also try building Font Awesome into the theme, instead of using the plugin. Would need to make sure this doesn't cause conflicts with plugins that are using Font Awesome though. https://fontawesome.com/how-to-use/customizing-wordpress/intro/getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant