You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observe that they're not using official/MojMap mappings for the field and method names
Description of issue:
The move to MojMaps everywhere is great, although ATs still appear to be mapped with SRG. If this could be changed to use MojMap that'll be great
The text was updated successfully, but these errors were encountered:
PaintNinja
added
Triage
This request requires the active attention of the Triage Team. Requires labelling or reviews.
1.20
labels
May 1, 2024
Correct, the problem is that it requires tooling changes. Namely that ATs are applied pre-decompile. And pre-decompile is in SRG names. We would either need to build a system into Forge's buildscripts to convert the config to SRG before decompile. Or teach AT about Mapped names.
If we were to move Forge's ATs to Official we would need to bake them to SRGs for userdev like we do the patch files.
So ya, I would like to do this but toolchain needs work.
PaintNinja
removed
the
Triage
This request requires the active attention of the Triage Team. Requires labelling or reviews.
label
May 1, 2024
Minecraft Version: 1.20.6
Forge Version: 50.0.2
Logs: N/A
Steps to Reproduce:
Description of issue:
The move to MojMaps everywhere is great, although ATs still appear to be mapped with SRG. If this could be changed to use MojMap that'll be great
The text was updated successfully, but these errors were encountered: