Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.6] ATs still use SRG mappings #9954

Open
PaintNinja opened this issue May 1, 2024 · 1 comment
Open

[1.20.6] ATs still use SRG mappings #9954

PaintNinja opened this issue May 1, 2024 · 1 comment
Labels

Comments

@PaintNinja
Copy link
Contributor

Minecraft Version: 1.20.6

Forge Version: 50.0.2

Logs: N/A

Steps to Reproduce:

  1. Clone Forge
  2. Check the accesstransformers.cfg file
  3. Observe that they're not using official/MojMap mappings for the field and method names

Description of issue:
The move to MojMaps everywhere is great, although ATs still appear to be mapped with SRG. If this could be changed to use MojMap that'll be great

@PaintNinja PaintNinja added Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. 1.20 labels May 1, 2024
@LexManos
Copy link
Member

LexManos commented May 1, 2024

Correct, the problem is that it requires tooling changes. Namely that ATs are applied pre-decompile. And pre-decompile is in SRG names. We would either need to build a system into Forge's buildscripts to convert the config to SRG before decompile. Or teach AT about Mapped names.

If we were to move Forge's ATs to Official we would need to bake them to SRGs for userdev like we do the patch files.

So ya, I would like to do this but toolchain needs work.

@PaintNinja PaintNinja removed the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants