Item method shouldCauseBlockBreakReset does not work when itemStack::hurt

[LIUKRAST]

Minecraft Version: 1.20.1

Forge Version: 47.2.20

I'm overriding these methods in my custom item

    @Override
    public void inventoryTick(ItemStack pStack, Level pLevel, Entity pEntity, int pSlotId, boolean pIsSelected) {
        if(pIsSelected) {
            if (!pLevel.isClientSide && pEntity instanceof LivingEntity entity) {
                pStack.hurtAndBreak(1, entity, (p_40992_) -> p_40992_.broadcastBreakEvent(EquipmentSlot.MAINHAND));
            }
        }
        super.inventoryTick(pStack, pLevel, pEntity, pSlotId, pIsSelected);
    }

    @Override
    public boolean shouldCauseBlockBreakReset(ItemStack oldStack, ItemStack newStack) {
        return oldStack.getItem() != newStack.getItem();
    }

which returns false cause sameDestroyTarget(BlockPos pos) in MultiPlayerGameMode has an && gate with
ItemStack.isSameItemSameTags(itemstack, this.destroyingItem), which for some reason is false.

Not sure if this is a bug, but i thought about reporting it anyways!

[LexManos]

You're right that is a messed up patch, the isSameItemSameTags should be removed. As the shouldCaueBlockBreakReset is the replacement for that method.

[LIUKRAST]

The method shouldCauseBlockBreakReset calls the tags check...