Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BootstrapContext registry lookup is not available for data gen registries #9629

Open
Cheaterpaul opened this issue Jul 8, 2023 · 0 comments
Labels
Triage This request requires the active attention of the Triage Team. Requires labelling or reviews.

Comments

@Cheaterpaul
Copy link
Contributor

Cheaterpaul commented Jul 8, 2023

Minecraft Version: 1.20.1

Forge Version: 47.1.0

Logs: https://gist.github.com/Cheaterpaul/20db541611824a6340bc40e631aba80c

Steps to Reproduce:

  1. call BootstapContext#registryLookup with a world gen registry eg. Registries.BIOME
  2. run the forge test data generation

Description of issue:
#9225 added the BootstapContext#registryLookup method and wrapped the registry lookup so it can be actually used. The problem here is that the datagen registries are using the UniversalLookup instead of a RegistryLookup. This causes BootstrapContext#registryLookup to fail as ClassCastException.

This can be reproduced in the forge dev environment by adding context.registryLookup(Registries.BIOME) in the BiomeModifierTest#BUILDER

@Cheaterpaul Cheaterpaul added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage This request requires the active attention of the Triage Team. Requires labelling or reviews.
Projects
None yet
Development

No branches or pull requests

1 participant