Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle 8 #908

Closed
gmitch215 opened this issue Feb 27, 2023 · 8 comments
Closed

Support Gradle 8 #908

gmitch215 opened this issue Feb 27, 2023 · 8 comments

Comments

@gmitch215
Copy link

Hello,

The newer versions of shadowJar require Gradle 8.0+ and above, and the latest versions of ForgeGradle don't support that yet.

Are there any plans to support it in the future?

@gigaherz
Copy link
Contributor

Yes, we always plan on supporting the latest version of gradle, as soon as we can. But this will probably not happen until after ForgeGradle 6.
Meanwhile, use an older version of the shadow plugin, corresponding to the version of gradle you use.

@gmitch215
Copy link
Author

Ok, thanks!

Is there any ETA for when this plans to happen?

@gigaherz
Copy link
Contributor

gigaherz commented Feb 27, 2023

No this project has a very small team of volunteers working in their spare time, we don't like to give ETAs that may not happen.

@gmitch215
Copy link
Author

Ok, thanks though.

@Matyrobbrt Matyrobbrt added planned Feature or enhancement is planned next breaking version Feature or enhancement is targeted towards the next breaking version labels Mar 6, 2023
@Matyrobbrt Matyrobbrt pinned this issue Mar 6, 2023
@BillyGalbreath

This comment was marked as off-topic.

@JasperTheMinecraftDev
Copy link

I was about to drop Forge support in my project(s) because everything else is starting to upgrade to newer and better things, but then someone pointed out a system property exists.

Just add this to your gradle.properties file

systemProp.net.minecraftforge.gradle.check.gradle=false

This will disable ForgeGradle from stopping you from using Gradle 8 ;)

Why is this marked as off-topic? It clearly isn't.

@gigaherz
Copy link
Contributor

gigaherz commented May 15, 2023

Due to limitations in Gradle itself, ForgeGradle has to rely on internals in order to do its job. These internals tend to change, specially in major versions.
We decided during development of FG 4 that each FG release would only support one major version, so that we can limit the number of conditional workarounds we need to have in the code.
Disabling these checks may work if you are lucky, but more likely it will break, in more or less subtle ways. So we cannot provide support for bypassing the version check.
Moreover, we always recomment running ForgeGradle via the gradle-wrapper system and the gradlew scripts, which means you don't need to have any version of gradle installed system-wide, and each project can launch a different version of gradle from the gradle version cache, which is automatically managed by gradle-wrapper. So there's no reason to force ForgeGradle to run on Gradle 8.
Marking it as offtopic isn't semantically ideal, but allows the post to remain available, but hidden.

[EDIT: typo]

@SizableShrimp
Copy link
Member

Completed in ForgeGradle 6.

@SizableShrimp SizableShrimp removed planned Feature or enhancement is planned next breaking version Feature or enhancement is targeted towards the next breaking version labels May 22, 2023
@Matyrobbrt Matyrobbrt unpinned this issue May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants