Server controlled skins

[killjoy1221]

There should be a packet sent on join to set player skins. This should reduce skin server load and allow the server to control who has what skin, just like vanilla.

A couple security concerns:

• Client should only accept skins from trusted servers
• Texture hosts should be on a whitelist defined by the server, approved by the player.
• Hosts not on the whitelist will not be downloaded.

Skulls

• Skin data can be stored in NBT, just like vanilla.
• Allows skulls to use the same skin as when the player died, just like vanilla.
• Singleplayer will follow the whitelist config to prevent malicious map makers

Progress can be tracked here. https://github.com/MineLittlePony/HDSkins/tree/server-skins

[Sollace]

Will you still be able to use custom skins on vanilla servers though?

[killjoy1221]

Yes. If the server doesn't provide any skin data, the old method will be used.

…

On Thu, Nov 28, 2019, 1:19 AM ­Sollace ***@***.***> wrote: Will you still be able to use custom skins on vanilla servers though? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AA2AQKQ2LYX44PYB4HHBAHDQV5PGDA5CNFSM4JSNGNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLSBUQ#issuecomment-559358162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2AQKUKUCS6JCM4E53BXC3QV5PGDANCNFSM4JSNGNRQ> .

[Sollace]

@killjoy1221 Ok, boomer. We'll see where this goes.

Remember to base your branch off 1.15-pre1 if you haven't already.

[killjoy1221]

I'll do that once you merge into master.

…

On Thu, Nov 28, 2019, 1:24 AM ­Sollace ***@***.***> wrote: @killjoy1221 <https://github.com/killjoy1221> Ok, boomer. We'll see where this goes. Remember to base your branch off 1.15-pre1 if you haven't already. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AA2AQKWSF5AZVFA3KOECOYLQV5P2RA5CNFSM4JSNGNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLSKPI#issuecomment-559359293>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2AQKQWHQZWE4LIWUPWQ3LQV5P2RANCNFSM4JSNGNRQ> .

[Sollace]

Happy rebasing then.

[killjoy1221]

Basic functionality is working. Just need to tackle security issues and the hostname whitelist.