Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code syntax highlighting for pots, comments and blogs #152

Closed
markharding opened this issue Jan 13, 2020 · 26 comments · May be fixed by #154
Closed

Code syntax highlighting for pots, comments and blogs #152

markharding opened this issue Jan 13, 2020 · 26 comments · May be fixed by #154

Comments

@markharding
Copy link
Member

Gitlab task - https://gitlab.com/minds/minds/issues/864

Ability to enter code blocks across the site.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 2.243 ETH (319.94 USD @ $142.64/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jan 13, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 7 months from now.
Please review their action plans below:

1) pengiundev has applied to start work (Funders only: approve worker | reject worker).

I'll add a new editor plugin which will use Highlight.js. I've used Highlight.js before and it'll take me a day probably.
2) jim-toth has been approved to start work.

Hi! I've begun investigative work on this issue as it's something I requested initially.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@jim-toth
Copy link
Contributor

https://gitlab.com/minds/front/-/merge_requests/735

Quick update on progress:

  • Code Highlight Module
  • Posts
  • Comments
  • Blog
  • Mobile

This is entirely a front-end solution, code to be highlighted is never executed.

Working with the Medium editor, I believe it would be best to add another plugin button for code highlighting. Any time a newline is entered into the editor it inserts </p><p> in between, which won't play well with code highlighting especially if the code being highlighted is HTML. I'll add a plugin to the Medium editor to highlight a code block by attempting to remove or prevent the </p><p> tags being inserted and wrap the block with <pre><code> as per Highlight.js convention.

For Mobile, I'll create a code-highlight component in react.

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@jim-toth
Copy link
Contributor

jim-toth commented Feb 3, 2020

Progress Update:

  • Code Highlight Module
  • Posts
  • Comments
  • Blog
    • Medium Editor Plugin
      • Functionality
      • Style
  • Mobile
    • Posts
    • Comments
    • Blog

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@jim-toth
Copy link
Contributor

jim-toth commented Feb 8, 2020

@jim-toth
Copy link
Contributor

Progress update: https://gitlab.com/minds/minds/issues/864#note_284708109

added feature flag for code highlight module

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@jim-toth
Copy link
Contributor

jim-toth commented Feb 17, 2020

Will be submitting an additional PR for mobile with update to issue shortly.

@jim-toth
Copy link
Contributor

@jim-toth
Copy link
Contributor

Waiting on some feedback for Mobile impl: https://gitlab.com/minds/minds/issues/864#note_291322982

@gitcoinbot
Copy link

@jim-toth Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@jim-toth
Copy link
Contributor

Still waiting on some feedback for implementation.

@jim-toth
Copy link
Contributor

Removed WIP status for front and engine MRs:

https://gitlab.com/minds/front/-/merge_requests/735/
https://gitlab.com/minds/engine/-/merge_requests/485

Mobile MR coming shortly.

@jim-toth
Copy link
Contributor

Bump

@gitcoinbot
Copy link

⚡️ A tip worth 2.24000 ETH (327.35 USD @ $146.14/ETH) has been granted to @jim-toth for this issue from @markharding. ⚡️

Nice work @jim-toth! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This Bounty has been completed.

Additional Tips for this Bounty:

  • markharding tipped 2.2400 ETH worth 320.95 USD to jim-toth.

@ottman ottman closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants