New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Error Duplicate class com.google.android.play.core.common #136
Comments
On my side to support Android 13 notifications and upgrade of wonderpush is required and somehow react-native-in-app-review triggers a build crash. Problem is that wonderpush is using com.google.android.play:core-common:2.0.0 Any suggestion how to apply an workaround or a fork will be greatly appreciated. |
Any update in this issue? |
FYI: I added a question and attached a bounty to it here: https://stackoverflow.com/questions/74692599/duplicate-class-in-com-google-android-play-core-in-common-and-review-modules |
there is no new progress in StackOverflow also @fdobre |
You can modify the build gradle file in the android project. Replace line 56 with implementation 'com.google.android.play:review:2.0.0' Then inside the AppReviewModule.java replace line 18 with import com.google.android.gms.tasks.Task; This will work with the wonderpush library as it is no longer making use of the play core library but instead using the review library only. I have forked it here: https://github.com/Solly74/react-native-in-app-review |
@MinaSamir11 please let us know if the code from the above fork looks OK from your perspective or if there is anything to be improved. If you think it's OK we could create a pull request. |
Thanks @Solly74 , It's work for me. |
Great Sol. |
@Solly74 |
@MinaSamir11 done :) |
Is this has been released ? I've still the issue with 4.2.1 😕 Thanks! |
still having the same issue when trying to run a react native project... Go to the documentation to learn how to Fix dependency resolution errors." |
@Etaliya Good to know thanks! I was able to test and it's fixes the issue. However have you any idea on a possible ETA for a release ? As I would be more confident to relies on a "fixed" version! Thanks! |
Sorry for the late response. The new release is now available, follow the new readme.md installation steps. For the public registry, the new release will be available in 10 days. |
Hello @MinaSamir11 ! Any update on the public registry release ? Thanks a lot! 💪 |
+1 looking to incorporate this package, running into the issue and would love to use an official version |
the new public version is available now V4.3.1 |
getting these error on version v4.3.3
|
Please mention your working env |
Hi @MinaSamir11, i'm facing the same issue that @zainulabdeen4 faced. env information is below:
|
I would check against any possible libraries that are using similar classes. I ran into this issue as well, but was ameliorated when I removed |
I have tried version 4.3.3 & 4.3.1 , in both version i am getting same issue above. @MinaSamir11 do you any suggestion for it. |
I have the same issue, so thought of excluding the conflicting dependencies from the package by this piece of code this resolves the dependency issue, |
According to this release note by the android dev team, the Removing for e.g, Note: make sure you are declaring all the libraries that are in use by your project, since i was also using |
nothing work any solution???? |
The text was updated successfully, but these errors were encountered: